linux-kernel - Re: [PATCH] staging: rtl8188eu: core: rtw_wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1501261706170.2693@hadrien>
Date:	Mon, 26 Jan 2015 17:06:46 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Julia Lawall <julia.lawall@...6.fr>
cc:	Kumar Amit Mehta <gmate.amit@...il.com>,
	gregkh@...uxfoundation.org, navin.patidar@...il.com,
	Larry.Finger@...inger.net, dan.carpenter@...cle.com,
	tapaswenipathak@...il.com, abelmoyo.ab@...il.com,
	devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: core: rtw_wlan_util.c: Fix for NULL
 dereference



On Mon, 26 Jan 2015, Julia Lawall wrote:

> On Mon, 26 Jan 2015, Kumar Amit Mehta wrote:
>
> > In rtw_check_bcn_info(), check the return value of kzalloc() before
> > dereferencing it, to avoid NULL pointer dereference.
> >
> > Signed-off-by: Kumar Amit Mehta <gmate.amit@...il.com>
> > ---
> >  drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> > index 3e9b6e9..a3ffc69 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> > @@ -931,6 +931,8 @@ int rtw_check_bcn_info(struct adapter  *Adapter, u8 *pframe, u32 packet_len)
> >  	}
> >
> >  	bssid = kzalloc(sizeof(struct wlan_bssid_ex), GFP_ATOMIC);
> > +	if (!bssid)
> > +		return _FAIL;
>
> I haven't looked at this issue in a while, but shouldn't this be
> OBD_ALLOC?

Sorry for the noise.  I assumed that both patches were for lustre, but
this one is not.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/