linux-kernel - Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150126164229.GB21293@sirena.org.uk>
Date:	Mon, 26 Jan 2015 16:42:29 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Bo Shen <voice.shen@...el.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, alsa-devel@...a-project.org,
	linux-sound@...r.kernel.org, Alexander Morozov <linux@...tdown.ru>
Subject: Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote:
> Le 16/01/2015 02:17, Bo Shen a écrit :

> >> Does this end up in the i2c_driver_id driver data or do we need some
> >> extra code when devtype is assigned to check for an of_node and look at
> >> the DT data instead?  That certainly used to be the case...

> > At the beginning I think as the same as you, and also add the code to 
> > get the data as I do in <drivers/misc/atmel-ssc.c>. However, as I 
> > remember, I2C seems only use the compatible string after the comma, that 
> > means only for "wlf,wm8904", it uses "wm8904" to match. So, I remove all 
> > the code I added, and just keep these, and it can get the device type 
> > correctly.

> > So, when I submit the patch and keep the code as simple as possible.

> I don't understand what's keeping this patch from being applied. Voice,
> do you mind re-sending?

I need to convince myself that the above actually works and is doing the
right thing; the above explanation sounds like if it works it might be
relying on a bug.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)