linux-kernel - [GIT PULL] cgroup fixes for v3.19-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150126170202.GC21242@htj.dyndns.org>
Date:	Mon, 26 Jan 2015 12:02:02 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, Li Zefan <lizefan@...wei.com>,
	cgroups@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
	"Suzuki K. Poulose" <Suzuki.Poulose@....com>,
	Will Deacon <will.deacon@....com>
Subject: [GIT PULL] cgroup fixes for v3.19-rc6

Hello, Linus.

The lifetime rules of cgroup hierarchies always have been somewhat
counter-intuitive and cgroup core tried to enforce that hierarchies
w/o userland-visible usages must die in finite amount of time so that
the controllers can be reused for other hierarchies; unfortunately,
this can't be implemented reasonably for the memory controller - the
kmemcg part doesn't have any way to forcefully drain the existing
usages, leading to an interruptible hang if a following mount attempts
to use the controller in any way.

So, it seems like we're stuck with "hierarchies live on till they die
whenever that may be" at least for now.  This pretty much confines
attaching controllers to hierarchies to before the hierarchies are
actively used by making dynamic configurations post active usages
unreliable.  This has never been reliable and should be fine in
practice given how cgroups are used.

After the patch, hierarchies aren't killed if it isn't already
drained.  A following mount attempt of the same mount options will
reuse the existing hierarchy.  Mount attempts with differing options
will fail w/ -EBUSY.

Thanks.

The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:

  Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.19-fixes

for you to fetch changes up to 3c606d35fe9766ede86a45273a628b320be13b45:

  cgroup: prevent mount hang due to memory controller lifetime (2015-01-22 10:26:43 -0500)

----------------------------------------------------------------
Johannes Weiner (1):
      cgroup: prevent mount hang due to memory controller lifetime

 kernel/cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index bb263d0..04cfe8a 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1909,7 +1909,7 @@ static void cgroup_kill_sb(struct super_block *sb)
 	 *
 	 * And don't kill the default root.
 	 */
-	if (css_has_online_children(&root->cgrp.self) ||
+	if (!list_empty(&root->cgrp.self.children) ||
 	    root == &cgrp_dfl_root)
 		cgroup_put(&root->cgrp);
 	else

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/