[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150126200403.GA32312@kroah.com>
Date: Mon, 26 Jan 2015 12:04:03 -0800
From: Greg KH <gregkh@...uxfoundation.org>
To: Mandeep Sandhu <mandeep.sandhu@...ninc.com>
Cc: hjk@...sjkoch.de, linux-kernel@...r.kernel.org,
viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/4] uio: Simplify the lifetime logic of struct
uio_device.
On Mon, Jan 26, 2015 at 11:57:30AM -0800, Mandeep Sandhu wrote:
> >> +
> >> + ret = kobject_set_name(&idev->device.kobj, "uio%d", idev->minor);
> >
> > dev_set_name()?
>
> There's another instance of use of kobject_set_name in
> uio_major_init(). Should I change that too ,or that should be done in
> a new (unrelated) patch?
Unrelated please, one logical change per patch is the rules.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists