linux-kernel - Re: [GIT PULL] PCI fixes for v3.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150126235334.GA11624@google.com>
Date:	Mon, 26 Jan 2015 17:53:34 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Tony Luck <tony.luck@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lucas Stach <l.stach@...gutronix.de>,
	Richard Zhu <Richard.Zhu@...escale.com>,
	Yinghai Lu <yinghai@...nel.org>,
	Marek Kordik <kordikmarek@...il.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Andreas Hartmann <andihartmann@...enet.de>,
	Alexey Voronkov <zermond@...il.com>,
	David Airlie <airlied@...ux.ie>,
	Alex Deucher <alexander.deucher@....com>
Subject: Re: [GIT PULL] PCI fixes for v3.19

On Mon, Jan 26, 2015 at 01:24:51PM -0800, Tony Luck wrote:
> On Mon, Jan 26, 2015 at 1:02 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> > Sorry for the inconvenience.  Can you collect a complete dmesg log and
> > "lspci -vv" output, too (from the kernel with the reverted commit)?
> > That will have more useful information than just /proc/iomem.
> 
> Full dmesg, lspci -vv, and bonus .config (CONFIG_PCI_IOV is indeed
> not set)

The ROM part is something we should fix:

  pci 0000:01:00.1: can't claim BAR 6 [mem 0xfffe0000-0xffffffff pref]: no compatible bridge window

The ROM BAR is probably disabled, and we shouldn't complain about this if
it's disabled.  Yinghai?

The stuff on bus 0000:80 looks like at least partly a firmware problem:

  ACPI: PCI Root Bridge [PCI1] (domain 0000 [bus 80-ff])
  acpi PNP0A08:01: host bridge window [io  0x9000-0xfffe]
  pci 0000:80:01.0: PCI bridge to [bus 81]
  pci 0000:80:01.0:   bridge window [io  0xa000-0xafff]
  pci 0000:80:01.0:   bridge window [mem 0xa0100000-0xa01fffff]
  pci 0000:80:13.0: reg 0x10: [mem 0xa0220000-0xa0220fff]

ACPI told us about an I/O port aperture, but didn't mention any MMIO
apertures through the host bridge.  Therefore, we have no MMIO space to
assign to the devices on [bus 80-ff].

But presumably these devices, e.g., the igb devices at 81:00.0 and 81:00.1
and the mpt device at 83:00.0, actually DO work, so the PCI1 host bridge
must actually forward some MMIO space that ACPI didn't tell us about.  I
think on x86, we would fall back to whatever the firmware left in those
BARs.  We should probably do the same on x86.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/