linux-kernel - Re: [GIT PULL] PCI fixes for v3.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Jan 2015 19:55:30 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Tony Luck <tony.luck@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lucas Stach <l.stach@...gutronix.de>,
	Richard Zhu <Richard.Zhu@...escale.com>,
	Marek Kordik <kordikmarek@...il.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Andreas Hartmann <andihartmann@...enet.de>,
	Alexey Voronkov <zermond@...il.com>,
	David Airlie <airlied@...ux.ie>,
	Alex Deucher <alexander.deucher@....com>
Subject: Re: [GIT PULL] PCI fixes for v3.19

On Mon, Jan 26, 2015 at 3:53 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Mon, Jan 26, 2015 at 01:24:51PM -0800, Tony Luck wrote:
>> On Mon, Jan 26, 2015 at 1:02 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
>> > Sorry for the inconvenience.  Can you collect a complete dmesg log and
>> > "lspci -vv" output, too (from the kernel with the reverted commit)?
>> > That will have more useful information than just /proc/iomem.
>>
>> Full dmesg, lspci -vv, and bonus .config (CONFIG_PCI_IOV is indeed
>> not set)
>
> The ROM part is something we should fix:
>
>   pci 0000:01:00.1: can't claim BAR 6 [mem 0xfffe0000-0xffffffff pref]: no compatible bridge window
>
> The ROM BAR is probably disabled, and we shouldn't complain about this if
> it's disabled.  Yinghai?

original ia64 code, has extra checking to hide the warning

-static int is_valid_resource(struct pci_dev *dev, int idx)
 {
-       unsigned int i, type_mask = IORESOURCE_IO | IORESOURCE_MEM;
-       struct resource *devr = &dev->resource[idx], *busr;

        if (!dev->bus)
-               return 0;
-
-       pci_bus_for_each_resource(dev->bus, busr, i) {
-               if (!busr || ((busr->flags ^ devr->flags) & type_mask))
-                       continue;
-               if ((devr->start) && (devr->start >= busr->start) &&
-                               (devr->end <= busr->end))
-                       return 1;
-       }
-       return 0;
-}

also that is used to skip pci_claim_resource calling for invalid ...

so the root resource is totally wrong from ACPI.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/