lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Jan 2015 12:34:13 +0530 From: Sumit Semwal <sumit.semwal@...aro.org> To: Russell King - ARM Linux <linux@....linux.org.uk> Cc: LKML <linux-kernel@...r.kernel.org>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, DRI mailing list <dri-devel@...ts.freedesktop.org>, Linaro MM SIG Mailman List <linaro-mm-sig@...ts.linaro.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, Tomasz Stanislawski <t.stanislaws@...sung.com>, Linaro Kernel Mailman List <linaro-kernel@...ts.linaro.org>, Rob Clark <robdclark@...il.com>, Daniel Vetter <daniel@...ll.ch>, Marek Szyprowski <m.szyprowski@...sung.com> Subject: Re: [RFCv2 2/2] dma-buf: add helpers for sharing attacher constraints with dma-parms Hi Russell! On 21 January 2015 at 23:01, Russell King - ARM Linux <linux@....linux.org.uk> wrote: > On Wed, Jan 21, 2015 at 09:46:47AM +0530, Sumit Semwal wrote: >> +static int calc_constraints(struct device *dev, >> + struct dma_buf_constraints *calc_cons) >> +{ >> + struct dma_buf_constraints cons = *calc_cons; >> + >> + cons.dma_mask &= dma_get_mask(dev); > > I don't think this makes much sense when you consider that the DMA > infrastructure supports buses with offsets. The DMA mask is th > upper limit of the _bus_ specific address, it is not a mask per-se. > > What this means is that &= is not the right operation. Moreover, > simply comparing masks which could be from devices on unrelated > buses doesn't make sense either. > > However, that said, I don't have an answer for what you want to > achieve here. Thanks for your comments! I suppose in that case, I will leave out the *dma_masks from this constraints information for now; we can re-visit it when a specific use case really needs information about the dma-masks of the attached devices. I will post an updated patch-set soon. > > -- > FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up > according to speedtest.net. -- Thanks and regards, Sumit Semwal Kernel Team Lead - Linaro Mobile Group Linaro.org │ Open source software for ARM SoCs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists