linux-kernel - Re: [PATCH 1/2][RFC] staging: Remove the Android alarm-dev driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1422350658.14015.9.camel@x220>
Date:	Tue, 27 Jan 2015 10:24:18 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	John Stultz <john.stultz@...aro.org>
Cc:	Valentin Rothberg <valentinrothberg@...il.com>,
	linux-kernel@...r.kernel.org, Greg Hackmann <ghackmann@...gle.com>,
	Elliott Hughes <enh@...gle.com>,
	Todd Poynor <toddpoynor@...gle.com>,
	Android Kernel Team <kernel-team@...roid.com>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/2][RFC] staging: Remove the Android alarm-dev driver

On Tue, 2015-01-20 at 13:42 -0800, John Stultz wrote:
> The functionality provided by the Android alarm-dev driver
> should now be present in the timerfd interface (thanks to
> Greg Hackmann and Todd Poynor).
> 
> As of Lollipop, AOSP can make use of the timerfd if
> alarm-dev is not present (though a fixup for setting the
> rtc time if rtc0 isn't the backing for _ALARM clockids has
> been applied post-Lollipop).
> 
> Thus, we should be able to remove alarm-dev from staging.
> 
> Cc: Greg Hackmann <ghackmann@...gle.com>
> Cc: Elliott Hughes <enh@...gle.com>
> Cc: Todd Poynor <toddpoynor@...gle.com>
> Cc: Android Kernel Team <kernel-team@...roid.com>
> Cc: Greg KH <gregkh@...uxfoundation.org>
> Signed-off-by: John Stultz <john.stultz@...aro.org>

This became commit 5da41e925656 ("staging: Remove the Android alarm-dev
driver") in today's linux-next (ie, next-20150127). I noticed because a
script I use to check linux-next spotted a minor problem with it.

>  drivers/staging/android/Kconfig              |   9 -

Here there should have been a line reading
   drivers/staging/android/Makefile             |   1 -  

>  drivers/staging/android/alarm-dev.c          | 446 ---------------------------
>  drivers/staging/android/android_alarm.h      |  41 ---
>  drivers/staging/android/uapi/android_alarm.h |  62 ----
>  4 files changed, 558 deletions(-)
>  delete mode 100644 drivers/staging/android/alarm-dev.c
>  delete mode 100644 drivers/staging/android/android_alarm.h
>  delete mode 100644 drivers/staging/android/uapi/android_alarm.h

Is a trivial patch to remove that Makefile line, the one that references
CONFIG_ANDROID_INTF_ALARM_DEV and alarm-dev.o, queued already?

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/