linux-kernel - RE: [PATCH v3 08/13] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A243641BFD35F4B@penmbx01>
Date:	Tue, 27 Jan 2015 10:11:00 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Sylvain Rochet <sylvain.rochet@...secur.com>
CC:	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alexandre.belloni@...e-electrons.com" 
	<alexandre.belloni@...e-electrons.com>,
	"peda@...ntia.se" <peda@...ntia.se>,
	"sergei.shtylyov@...entembedded.com" 
	<sergei.shtylyov@...entembedded.com>,
	"linux@...im.org.za" <linux@...im.org.za>
Subject: RE: [PATCH v3 08/13] pm: at91: the standby mode uses the same sram
 function as the suspend to memory mode

Hi Sylvain,

Thanks a lot.

> -----Original Message-----
> From: Sylvain Rochet [mailto:sylvain.rochet@...secur.com]
> Sent: Tuesday, January 27, 2015 6:08 PM
> To: Yang, Wenyou
> Cc: Ferre, Nicolas; linux@....linux.org.uk; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; alexandre.belloni@...e-electrons.com;
> peda@...ntia.se; sergei.shtylyov@...entembedded.com; linux@...im.org.za
> Subject: Re: [PATCH v3 08/13] pm: at91: the standby mode uses the same sram
> function as the suspend to memory mode
> 
> Hello Wenyou,
> 
> On Tue, Jan 27, 2015 at 01:58:20PM +0800, Wenyou Yang wrote:
> >
> > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index
> > 0377c0d..d967c31 100644
> > --- a/arch/arm/mach-at91/pm.c
> > +++ b/arch/arm/mach-at91/pm.c
> > @@ -71,7 +71,7 @@ static int at91_pm_begin(suspend_state_t state)
> >   * Verify that all the clocks are correct before entering
> >   * slow-clock mode.
> >   */
> > -static int at91_pm_verify_clocks(void)
> > +static int at91_pm_verify_clocks(suspend_state_t state)
> >  {
> >  	unsigned long scsr;
> >  	int i;
> > @@ (...)
> 
> Unused state argument, it was added in v2, this is just a trace of a reverted v2
> change not fully cleaned.

Yes, not clear.
> 
> 
> > +		if (!at91_pm_verify_clocks(state))
> > +			goto error;
> 
> Ditto.
> 
> 
> Sylvain

Best Regards,
Wenyou Yang