| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150127130804.GA25333@sudip-PC> Date: Tue, 27 Jan 2015 18:38:04 +0530 From: Sudip Mukherjee <sudipm.mukherjee@...il.com> To: Tomi Valkeinen <tomi.valkeinen@...com> Cc: Thomas Winischhofer <thomas@...ischhofer.net>, Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] video: fbdev: sis: remove unused variables On Mon, Jan 26, 2015 at 02:37:26PM +0200, Tomi Valkeinen wrote: > On 22/01/15 17:31, Sudip Mukherjee wrote: > > removed some variables which were not used. Few calls to SiS_GetReg() > > were left behind as they are reading from the hardare, removing them > > might affect the overall functionality. > > > > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org> > > --- > > This patch will generate checkpatch error, to fix that error we need > > to change the style of init.c and init301.c > > > > drivers/video/fbdev/sis/init.c | 33 +++++---------------------------- > > drivers/video/fbdev/sis/init301.c | 10 ++-------- > > drivers/video/fbdev/sis/sis_main.c | 9 ++++----- > > 3 files changed, 11 insertions(+), 41 deletions(-) > > Are you able to test this? > > The patch doesn't look too complex, but it's still slightly too complex > for me to comfortably merge it without any testing. No. It is not tested on actual hardware. Sudip > > Tomi > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists