lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Jan 2015 19:00:19 +0530 From: Sudip Mukherjee <sudipm.mukherjee@...il.com> To: Tomi Valkeinen <tomi.valkeinen@...com> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] OMAPDSS: hdmi5: remove unneeded check On Mon, Jan 26, 2015 at 02:41:42PM +0200, Tomi Valkeinen wrote: > On 13/01/15 18:46, Sudip Mukherjee wrote: > > prior to this check we are checking for word_length_16b and if word_length_16b > > is false then we are returning with -EINVAL. > > So at this point word_length_16b can only be true. > > True, but it looks to me the code may be extended in the future. > > And if it would be clear that it won't be extended in the future, then > there's more code changes needed to reflect that (the whole > word_length_16b can be removed, etc). you are the author of the code, so you will know if it will be extended .. :) Sudip > > Tomi > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists