linux-kernel - Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFo363x7NGEctNwHkpn-6HkAu15qu-ZFtt73mJcWZrce4g@mail.gmail.com>
Date:	Tue, 27 Jan 2015 15:06:56 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	Chris Ball <chris@...ntf.net>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2

On 26 January 2015 at 11:23, Jean Delvare <jdelvare@...e.de> wrote:
> I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are
> only needed on the MMP architecture. So add a hardware dependency on
> ARCH_MMP, so that other users don't get to build useless drivers.

I would rather see the default option to be N.
Thus those configurations that needs this driver will have to select it.

Kind regards
Uffe

>
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Chris Ball <chris@...ntf.net>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Eric Miao <eric.y.miao@...il.com>
> Acked-by: Haojian Zhuang <haojian.zhuang@...il.com>
> ---
> This patch was already sent on:
>  * 2014-04-23
>  * 2014-06-16
>
>  drivers/mmc/host/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
>
> --- linux-3.19-rc6.orig/drivers/mmc/host/Kconfig        2015-01-26 10:30:56.472182636 +0100
> +++ linux-3.19-rc6/drivers/mmc/host/Kconfig     2015-01-26 11:13:33.669863314 +0100
> @@ -228,6 +228,7 @@ config MMC_SDHCI_PXAV3
>         tristate "Marvell MMP2 SD Host Controller support (PXAV3)"
>         depends on CLKDEV_LOOKUP
>         depends on MMC_SDHCI_PLTFM
> +       depends on ARCH_MMP || COMPILE_TEST
>         default CPU_MMP2
>         help
>           This selects the Marvell(R) PXAV3 SD Host Controller.
> @@ -240,6 +241,7 @@ config MMC_SDHCI_PXAV2
>         tristate "Marvell PXA9XX SD Host Controller support (PXAV2)"
>         depends on CLKDEV_LOOKUP
>         depends on MMC_SDHCI_PLTFM
> +       depends on ARCH_MMP || COMPILE_TEST
>         default CPU_PXA910
>         help
>           This selects the Marvell(R) PXAV2 SD Host Controller.
>
>
> --
> Jean Delvare
> SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/