linux-kernel - Re: [PATCH 2/2] drivers: usb: dwc2: remove 'force' parameter from kill_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150127154232.GE14623@saruman.tx.rr.com>
Date:	Tue, 27 Jan 2015 09:42:32 -0600
From:	Felipe Balbi <balbi@...com>
To:	Robert Baldyga <r.baldyga@...sung.com>
CC:	<balbi@...com>, <paulz@...opsys.com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] drivers: usb: dwc2: remove 'force' parameter from
 kill_all_requests()

On Mon, Jan 05, 2015 at 10:31:35AM +0100, Robert Baldyga wrote:
> This patch fixes in simpler way the bug described in [1] and [2]. It
> looks like DWC2 is the only UDC driver that doesn't force usb requests
> to complete in ep_disable() function. This causes described problem,
> because we have no guarantee that all requests will be completed before
> unbind of usb function.
> 
> To fix this problem we force all requests of disabled endpoint to complete.
> Also currently running request is not handled. This allowed to simplify
> code of kill_all_requests() function, because 'force' parameter is always
> set to true, so we don't need it anymore.
> 
> In s3c_hsotg_rx_data() we change function used to print message when active
> request is NULL from dev_warn() to dev_dbg(), because such situation is
> harmless for driver and now it can take place during normal endpoint
> disabling.
> 
> [1] https://lkml.org/lkml/2014/12/9/283
> [2] https://lkml.org/lkml/2014/12/12/360
> 
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>

this fails to apply:

checking file drivers/usb/dwc2/gadget.c
Hunk #1 succeeded at 2602 (offset 35 lines).
Hunk #2 FAILED at 2588.
Hunk #3 succeeded at 2645 (offset 36 lines).
Hunk #4 FAILED at 2924.
2 out of 4 hunks FAILED

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)