linux-kernel - Re: [PATCH] tracing: Remove newline from trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150127120558.0b428aac@gandalf.local.home>
Date:	Tue, 27 Jan 2015 12:05:58 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: Remove newline from trace_printk warning
 banner

On Tue, 27 Jan 2015 17:17:20 +0100
Borislav Petkov <bp@...en8.de> wrote:

> From: Borislav Petkov <bp@...e.de>
> 
> Remove the output-confusing newline below:
> 
> [    0.191328]
> **********************************************************
> [    0.191493] **   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **
> [    0.191586] **                                                      **
> ...
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>  kernel/trace/trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 4a9079b9f082..7a04946ffb06 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2036,7 +2036,7 @@ void trace_printk_init_buffers(void)
>  
>  	/* trace_printk() is for debug use only. Don't use it in production. */
>  
> -	pr_warning("\n**********************************************************\n");
> +	pr_warning("**********************************************************\n");

Actually, could you just move the \n to another pr_warning. Because
this can print on console text that makes it look weird too:

login: [    0.191328] **********************************************************
[    0.191493] **   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **
[    0.191586] **                                                      **

-- Steve

>  	pr_warning("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
>  	pr_warning("**                                                      **\n");
>  	pr_warning("** trace_printk() being used. Allocating extra memory.  **\n");

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/