linux-kernel - Re: [PATCH v2 3/3] mm: cma: release trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Jan 2015 15:13:52 -0500
From:	Sasha Levin <sasha.levin@...cle.com>
To:	Joonsoo Kim <iamjoonsoo.kim@....com>
CC:	linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
	akpm@...ux-foundation.org, lauraa@...eaurora.org
Subject: Re: [PATCH v2 3/3] mm: cma: release trigger

On 01/27/2015 01:25 PM, Sasha Levin wrote:
> On 01/27/2015 03:10 AM, Joonsoo Kim wrote:
>>> >> +		if (mem->n <= count) {
>>>> >> > +			cma_release(cma, mem->p, mem->n);
>>>> >> > +			count -= mem->n;
>>>> >> > +			kfree(mem);
>>>> >> > +		} else {
>>>> >> > +			cma_release(cma, mem->p, count);
>>>> >> > +			mem->p += count;
>>>> >> > +			mem->n -= count;
>>>> >> > +			count = 0;
>>>> >> > +			cma_add_to_cma_mem_list(mem);
>>>> >> > +		}
>>>> >> > +	}
>> > If order_per_bit is not 0 and count used in cma_release() is
>> > different with the count used in cma_alloc(), problem could
>> > occur since bitmap management code can't handle that situation.
>> > 
>> > Could we just disable this case in this testing module?
> How should it behave then? Just free a max of 'count' pages and
> stop beforehand if we're going to go over it?

Actually, Can I just check for order_per_bit == 0 and execute it
then? I don't want to avoid testing these paths.


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/