linux-kernel - Re: [PATCH 0/6] Fix fbtft/fb_pcd8544.c coding style errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1422391651.13127.3.camel@perches.com>
Date:	Tue, 27 Jan 2015 12:47:31 -0800
From:	Joe Perches <joe@...ches.com>
To:	Heba Aamer <heba93aamer@...il.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	notro@...nnes.org, thomas.petazzoni@...e-electrons.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] Fix fbtft/fb_pcd8544.c coding style errors

On Tue, 2015-01-27 at 22:30 +0200, Heba Aamer wrote:
> This patch set fixes most of the checkpatch.pl coding
> style errors found in drivers/staging/fbtft/fb_pcd8544.c
> 
> Heba Aamer (6):
>   staging: fbtft: fix space required after that ';'
>   staging: fbtft: fix spaces required around that '='
>   staging: fbtft: fix spaces required around that '<'

I suppose this is OK, but I think it's
better to do all the horizontal whitespace
changes in the same patch.

It's trivial and easy to verify all-at-once
instead of modifying the same line multiple
times.

It's also nice to say that git diff -w shows
no difference and that objdiff is empty.

>   staging: fbtft: fix trailing whitespace



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/