linux-kernel - Re: Linux 3.18.2 / xen 4.4.1 dom0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54C81755.4080502@oracle.com>
Date:	Tue, 27 Jan 2015 17:55:17 -0500
From:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	James Dingwall <james@...gwall.me.uk>, linux-kernel@...r.kernel.org
Subject: Re: Linux 3.18.2 / xen 4.4.1 dom0 - microcode oops

On 01/27/2015 05:12 PM, Borislav Petkov wrote:
> Hey Boris,
>
> On Thu, Jan 22, 2015 at 04:30:02PM +0100, Borislav Petkov wrote:
>> On Thu, Jan 22, 2015 at 09:53:04AM -0500, Boris Ostrovsky wrote:
>>> Alternatively, we could return an error (-EINVAL?) from
>>> microcode_init() when either of these two conditions is true.
>> Yeah, this should be the right fix.
>>
>> James, does that fix your issue? (It should.)
>>
>> ---
>> diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
>> index 15c29096136b..36a83617eb21 100644
>> --- a/arch/x86/kernel/cpu/microcode/core.c
>> +++ b/arch/x86/kernel/cpu/microcode/core.c
>> @@ -552,7 +552,7 @@ static int __init microcode_init(void)
>>   	int error;
>>   
>>   	if (paravirt_enabled() || dis_ucode_ldr)
>> -		return 0;
>> +		return -EINVAL;
>>   
>>   	if (c->x86_vendor == X86_VENDOR_INTEL)
>>   		microcode_ops = init_intel_microcode();
> would you do the honor and write a proper patch? You found the bug so...
> :-D


Will do. This needs to go to stable as well, right?

-boris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/