linux-kernel - Re: [PATCH 4/5] sched/rt: Consider deadline tasks in cpupri

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150127180438.445d8e76@gandalf.local.home>
Date:	Tue, 27 Jan 2015 18:04:38 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Xunlei Pang <pang.xunlei@...aro.org>, linux-kernel@...r.kernel.org,
	Juri Lelli <juri.lelli@...il.com>
Subject: Re: [PATCH 4/5] sched/rt: Consider deadline tasks in cpupri_find()

On Tue, 27 Jan 2015 13:58:59 +0100
Peter Zijlstra <peterz@...radead.org> wrote:


> Not a bad idea, Cc'ed Steve who likes to look after the RT bits,
> excessive quoting for him.

Yep I do.


> > index ade2958..48c9576 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -5652,6 +5652,8 @@ static int init_rootdomain(struct root_domain *rd)
> >  
> >  	if (cpupri_init(&rd->cpupri) != 0)
> >  		goto free_rto_mask;
> > +
> > +	rd->cpupri.cpudl = &rd->cpudl;
> 
> This is disgusting though; it breaks the cpuri abstraction. Why not pass
> in the mask in the one place you actually need it?

Yeah, probably should change cpupri_init() to take the rd->cpudl as a
parameter.

Rest looks good (ignoring Peter's other comment that he realized wasn't
an issue).

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/