linux-kernel - Re: [PATCH] sound: sscape: add missing include of asm/io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Jan 2015 15:56:39 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] sound: sscape: add missing include of asm/io.h

At Wed, 28 Jan 2015 15:54:04 +0100,
Arnd Bergmann wrote:
> 
> The soundscape driver uses the ISA inb/outb functions declared
> in asm/io.h, so it needs to include this header to avoid
> a build error:
> 
> sscape.c: In function 'sscape_write_unsafe':
> sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Could you correct asm/io.h with linux/io.h in subject and description
to match with the actual change?


thanks,

Takashi

> 
> diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
> index 018ab140c2be..7b248cdf06e2 100644
> --- a/sound/isa/sscape.c
> +++ b/sound/isa/sscape.c
> @@ -23,6 +23,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/err.h>
> +#include <linux/io.h>
>  #include <linux/isa.h>
>  #include <linux/delay.h>
>  #include <linux/firmware.h>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/