linux-kernel - Re: [PATCH 3.4 000/177] 3.4.106-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1422462646.2709.24.camel@decadent.org.uk>
Date:	Wed, 28 Jan 2015 16:30:46 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	lizf@...nel.org
Cc:	stable@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux@...ck-us.net, satoru.takeuchi@...il.com,
	Zefan Li <lizefan@...wei.com>,
	Jeffrey Knockel <jeffk@...unm.edu>
Subject: Re: [PATCH 3.4 000/177] 3.4.106-rc1 review

On Wed, 2015-01-28 at 12:07 +0800, lizf@...nel.org wrote:
> From: Zefan Li <lizefan@...wei.com>
> 
> This is the start of the stable review cycle for the 3.4.106 release.
> There are 177 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Fri Jan 30 03:58:34 UTC 2015.
> Anything received after that time might be too late.
> 
> A combined patch relative to 3.4.105 will be posted as an additional
> response to this.  A shortlog and diffstat can be found below.

You're missing Jeffrey Knockel's fix for the regression in IPv4
identifier selection.  I can't find the original message now, but you
should be able to apply this:

From: Jeffrey Knockel <jeffk@...unm.edu>
Date: Wed, 12 Nov 2014 07:47:20 -0700
Subject: [PATCH] Patch for 3.2.x, 3.4.x IP identifier regression

With commits 73f156a6e8c1 ("inetpeer: get rid of ip_id_count") and
04ca6973f7c1 ("ip: make IP identifiers less predictable"), IP
identifiers are generated from a counter chosen from an array of
counters indexed by the hash of the outgoing packet header's source
address, destination address, and protocol number.  Thus, in
__ip_make_skb(), we must now call ip_select_ident() only after setting
these fields in the IP header to prevent IP identifiers from being
generated from bogus counters.

IP id sequence before fix: 18174, 5789, 5953, 59420, 59637, ...
After fix: 5967, 6185, 6374, 6600, 6795, 6892, 7051, 7288, ...

Signed-off-by: Jeffrey Knockel <jeffk@...unm.edu>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
Cc: Eric Dumazet <edumazet@...gle.com>
---
 net/ipv4/ip_output.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1346,10 +1346,10 @@ struct sk_buff *__ip_make_skb(struct sock *sk,
 	iph->ihl = 5;
 	iph->tos = inet->tos;
 	iph->frag_off = df;
-	ip_select_ident(skb, sk);
 	iph->ttl = ttl;
 	iph->protocol = sk->sk_protocol;
 	ip_copy_addrs(iph, fl4);
+	ip_select_ident(skb, sk);
 
 	if (opt) {
 		iph->ihl += opt->optlen>>2;
--- END ---

I think you should also pick commit 5188cd44c55d ("drivers/net, ipv6:
Select IPv6 fragment idents for virtio UFO packets"); my backport for
3.2 (commit 540aa5b743b3) will probably work for 3.4 as well.

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)