lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54C85454.6070303@cn.fujitsu.com>
Date:	Wed, 28 Jan 2015 11:15:32 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
	Eric Sandeen <sandeen@...deen.net>,
	Dave Chinner <david@...morbit.com>
Subject: Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue
 which can stall whole worker_pool

On 01/28/2015 10:24 AM, Tejun Heo wrote:
> On Wed, Jan 28, 2015 at 09:51:54AM +0800, Lai Jiangshan wrote:
>> On 01/28/2015 09:26 AM, Greg Kroah-Hartman wrote:
>>> 3.18-stable review patch.  If anyone has any objections, please let me know.
>>
>>
>> I don't think it is a bug-fix.
>> It is just a good cleanup.
> 
> It is a bug fix, for a rare but potentially critical issue.  Please
> read the patch description.  It contains ample information on what's
> broken and also the link to the original bug report.
> 

Sorry, you are right.

Was the bug introduced at the first time when maybe_create_worker() was
introduced?  Although manage_workers()/maybe_create_worker() was changed a bit,
the stable-tree team can simply make manage_workers() return true to fix
this bug for the very old kernel versions.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ