linux-kernel - Re: arm64: USB_ARCH_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1501281621330.19947@utopia.booyaka.com>
Date:	Wed, 28 Jan 2015 16:25:04 +0000 (UTC)
From:	Paul Walmsley <paul@...an.com>
To:	Paul Bolle <pebolle@...cali.nl>
cc:	Valentin Rothberg <valentinrothberg@...il.com>,
	Thierry Reding <treding@...dia.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: arm64: USB_ARCH_HAS_EHCI

On Wed, 28 Jan 2015, Paul Bolle wrote:

> On Tue, 2015-01-27 at 21:31 +0000, Paul Walmsley wrote:
> > On Tue, 27 Jan 2015, Paul Bolle wrote:
> > 
> > > Your commit d035fdfa27ac ("arm64: Add Tegra132 support") is included in
> > > today's linux-next (ie, next-20150127). I noticed because a script I use
> > > to check linux-next spotted a minor problem with it.
> > > 
> > > It adds a select for the Kconfig symbol USB_ARCH_HAS_EHCI. That Kconfig
> > > was obsoleted in v3.11 and removed in v3.15. See commit b797b76fb464
> > > ("usb: host: remove USB_ARCH_HAS_?HCI"). That select is now a nop.
> > > 
> > > Should I submit the trivial patch to remove that line or do you prefer
> > > to do that yourself?
> > 
> > Thanks, I'll post a new version.
> 
> I just noticed that your commit added another unneeded select. The entry
> for ARCH_TEGRA selects HAVE_SMP, but HAVE_SMP is only available on arm
> or xtensa. There's no point in selecting it in arm64.

OK thanks, will roll that in.  Looks like Thierry's already sent a pull 
request for the original patch, so I'll probably just send a follow-up.

Is the Kconfig checker script you mentioned on Tuesday available in the 
mainline tree?  I don't see anything obvious under the "Static Analysers" 
section of the Makefile, but perhaps I'm overlooking it.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/