linux-kernel - Re: [PATCH] x86, microcode: Return error from driver init code when loader is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150128110634.GG12929@pd.tnic>
Date:	Wed, 28 Jan 2015 12:06:34 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org, james@...gwall.me.uk,
	stable@...r.kernel.org.#.3.18
Subject: Re: [PATCH] x86, microcode: Return error from driver init code when
 loader is disabled

On Tue, Jan 27, 2015 at 09:21:09PM -0500, Boris Ostrovsky wrote:
> Commits 65cef1311d5d ("x86, microcode: Add a disable chicken bit") and
> a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on
> paravirt") allow microcode driver skip initialization when microcode
> loading is not permitted.
> 
> However, they don't prevent the driver from being loaded since the
> init code returns 0. If at some point later the driver gets unloaded
> this will result in an oops while trying to deregister the (never
> registered) device.
> 
> To avoid this, make init code return an error on paravirt or when
> microcode loading is disabled. The driver will then never be loaded.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Reported-by: James Digwall <james@...gwall.me.uk>
> Cc: stable@...r.kernel.org # 3.18

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/