linux-kernel - Re: [PATCH] ASoC: rx51: do not fail if could not get jack detection gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201501281509.17333@pali>
Date:	Wed, 28 Jan 2015 15:09:17 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Pavel Machek <pavel@....cz>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	linux-omap@...r.kernel.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, Sebastian Reichel <sre@...ian.org>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Aaro Koskinen <aaro.koskinen@....fi>
Subject: Re: [PATCH] ASoC: rx51: do not fail if could not get jack detection gpio

> > > It is quite important to keep qemu working, really.
> > > Debugging early boot on hardware is very hard, for
> > > example.
> > 
> > I understand, but looking at the history of the driver, if
> > it fails now with the jack-detection GPIO, it should have
> > been failing in the past as well. What triggered this
> > sudden qemu does not like jack-detection GPIO? Before the
> > devm_gpiod_get() conversion the driver should have failed in
> > snd_soc_jack_add_gpios() phase.
> 
> With 3.12 kernel rx51-audio driver loads without any problem.
> So there is some regression. Here is dmesg log from 3.12
> kernel:
> 
> [    1.123779] rx51-audio rx51-audio:  tlv320aic3x-hifi <->
> omap- mcbsp.2 mapping ok
> [    1.130737] tlv320aic3x-codec 2-0019: ASoC: mux b Right
> Line1L Mux has no paths
> [    1.131347] tlv320aic3x-codec 2-0019: ASoC: mux b Left
> Line1R Mux has no paths
> [    1.133697] tlv320aic3x-codec 2-0018: ASoC: mux Right
> Line1L Mux has no paths
> [    1.134307] tlv320aic3x-codec 2-0018: ASoC: mux Left Line1R
> Mux has no paths
> [    1.137451] input: RX-51 AV Jack as /devices/platform/rx51-
> audio/sound/card0/input2
> 
> I will try to investigate where is problem...
> 

Ok, problem found and solved. Please drop my patch and sorry for 
a noise.

As is visible in above lines AV Jack is working fine on non DT 
kernel (3.12) and fails on DT kernel.

Reason is because I have another non-mainline driver which is 
using GPIOs and in non DT kernel is initialized *after* audio. 
And in DT kernel is initialized *before* audio.

Once I changed my non-mainline driver to not request av jack 
gpio, rx51-audio driver loads fine in qemu.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)