linux-kernel - Re: [PATCH v4] trace: Use 64-bit timekeeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150128095349.6a3537a2@gandalf.local.home>
Date:	Wed, 28 Jan 2015 09:53:49 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Tina Ruchandani <ruchandani.tina@...il.com>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v4] trace: Use 64-bit timekeeping

On Wed, 28 Jan 2015 19:46:11 +0530
Tina Ruchandani <ruchandani.tina@...il.com> wrote:

> The ring_buffer_producer uses 'struct timeval' to measure
> its start and end times. 'struct timeval' on 32-bit systems
> will have its tv_sec value overflow in year 2038 and beyond.
> This patch replaces struct timeval with 'ktime_t' which uses
> 64-bit representation for nanoseconds.
> 
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Suggested-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Tina Ruchandani <ruchandani.tina@...il.com>
> ---
> Changes in v4:
> 	- Fix typo in commit message.
> 	- Avoid typecast to 'long long' by defining RUN_TIME as '10ULL'
> 	  instead of '10'.

Although I have not tested this, this patch looks fine to me. Is this
going to go through some cleanup tree or should I just pull it?

-- Steve


> Changes in v3:
> 	- Use a more efficient way to compute condition for exiting loop.
> 	- Fix variable naming - all caps is only for macros.
> Changes in v2:
> 	- Use ktime_t instead of timespec64 for efficiency reasons.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/