| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <54CA2F41.8060602@mev.co.uk> Date: Thu, 29 Jan 2015 13:01:53 +0000 From: Ian Abbott <abbotti@....co.uk> To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>, H Hartley Sweeten <hsweeten@...ionengravers.com> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: comedi: drivers: dt2814: Removed variables that is never used On 29/01/15 12:52, Ian Abbott wrote: > On 28/01/15 22:33, Rickard Strandqvist wrote: >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist >> <rickard_strandqvist@...ctrumdigital.se> >> --- >> drivers/staging/comedi/drivers/dt2814.c | 13 ++++--------- >> 1 file changed, 4 insertions(+), 9 deletions(-) > > Good, apart from the bad English! > > Reviewed-by: Ian Abbott <abbotti@....co.uk> On second thoughts, I retract my 'Reviewed-by'. The patch actually serves to point out a glaring bug in the original code, in that it acquires data in the interrupt routine but just throws it all away! -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@....co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists