linux-kernel - Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54CA3F53.70107@roeck-us.net>
Date:	Thu, 29 Jan 2015 06:10:27 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Robert Rosengren <robert.rosengren@...s.com>,
	Jean Delvare <jdelvare@...e.de>
CC:	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	Johan Adolfsson <johana@...s.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

On 01/29/2015 04:07 AM, Robert Rosengren wrote:
> On 01/29/2015 08:05 AM, Guenter Roeck wrote:
>> Ah, don't bother then. I should hopefully get the samples in a couple of days.
>
> i2cdump was easily built, so here is the output:
>       0,8  1,9  2,a  3,b  4,c  5,d  6,e  7,f
> 00: 1301 1301 1301 1301 1301 1301 1301 1301
> 08: 4101 6901 6a01 6901 6901 6901 6901 6901
> 10: 0200 0100 0100 0100 0100 0100 0100 0100
> 18: 0100 0100 0100 0100 0100 0100 0100 0100
> 20: 0200 0100 0100 0100 0100 0100 0100 0100
> 28: 0100 0100 0100 0100 0100 0100 0100 0100
> 30: 0200 0100 0100 0100 0100 0100 0100 0100
> 38: 0100 0100 0100 0100 0100 0100 0100 0100
> 40: 0000 0000 0000 0000 0000 0000 0000 0000
> 48: 0000 0000 0000 0000 0000 0000 0000 0000
> 50: 0200 0100 0100 0100 0100 0100 0100 0100
> 58: 0100 0100 0100 0100 0100 0100 0200 0100
> 60: 0100 0100 0100 0100 0100 0100 0100 0100
> 68: 0100 0100 0100 0100 0100 0100 0100 0100
> 70: 0200 0100 0100 0100 0100 0100 0100 0100
> 78: 0100 0100 0100 0100 0100 0100 0100 0100
> 80: 6501 2401 1701 1401 1301 1301 1301 1301
> 88: 4201 6901 6901 6901 6901 6901 6901 6901
> 90: 0200 0100 0100 0100 0100 0100 0100 0100
> 98: 0100 0100 0100 0100 0100 0100 0100 0100
> a0: 6701 2501 1901 1601 1501 1501 1501 1501
> a8: 4401 6c01 6c01 6c01 6c01 6c01 6c01 6c01
> b0: 0200 0100 0100 0100 0100 0100 0100 0100
> b8: 0100 0100 0100 0100 0100 0100 0100 0100
> c0: 0200 0100 0100 0100 0100 0100 0100 0100
> c8: 0100 0100 0100 0100 0100 0100 0100 0100
> d0: 0200 0100 0100 0100 0100 0100 0100 0100
> d8: 0100 0100 0100 0100 0100 0100 0100 0100
> e0: 6701 2801 1b01 1701 1601 1501 1501 1501
> e8: 4401 6c01 6c01 6c01 6c01 6c01 6c01 6c01
> f0: 0200 0100 0100 0100 0100 0100 0100 0100
> f8: 0100 0100 0100 0100 0100 0100 0100 0100
>
> I checked the value at 0x84 (channel 0, and using single-ended and external reference). I got 222 when reading from corresponding sysfs, and 0x131 * lsb_resolution (806) / 1000 is 222 in decimal. So it seems as data above is correct.
>
> Is the data what you expected?
>
Yes and no. With the above data, the old version of the driver
(non-regmap) works as expected. The driver supporting regmap,
however, needs the byte swap to work correctly.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/