linux-kernel - Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54CA463C.9090804@mev.co.uk>
Date:	Thu, 29 Jan 2015 14:39:56 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Julia Lawall <julia.lawall@...6.fr>,
	Heena Sirwani <heenasirwani@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: mite: Removed variables that
 is never used

On 28/01/15 22:36, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/mite.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> index ffc9e61..8d2903b 100644
> --- a/drivers/staging/comedi/drivers/mite.c
> +++ b/drivers/staging/comedi/drivers/mite.c
> @@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
>   unsigned mite_dma_tcr(struct mite_channel *mite_chan)
>   {
>   	struct mite_struct *mite = mite_chan->mite;
> -	int lkar;
>
> -	lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> +	readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
>   	return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
>   }
>   EXPORT_SYMBOL_GPL(mite_dma_tcr);
>

Reading the MITE_LKAR(channel) register won't have any side-effects, so 
that call to readl() can be removed altogether.  In previous versions of 
the driver, the value of lkar was only used in debugging messages.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/