linux-kernel - Re: [PATCH] staging: comedi: drivers: ni_atmio: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54CA4737.9020300@mev.co.uk>
Date:	Thu, 29 Jan 2015 14:44:07 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: ni_atmio: Removed variables
 that is never used

On 28/01/15 22:37, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/ni_atmio.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index 0c5ff28..301f154 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -300,7 +300,6 @@ static int ni_atmio_attach(struct comedi_device *dev,
>   			   struct comedi_devconfig *it)
>   {
>   	const struct ni_board_struct *boardtype;
> -	struct ni_private *devpriv;
>   	struct pnp_dev *isapnp_dev;
>   	int ret;
>   	unsigned long iobase;
> @@ -310,7 +309,6 @@ static int ni_atmio_attach(struct comedi_device *dev,
>   	ret = ni_alloc_private(dev);
>   	if (ret)
>   		return ret;
> -	devpriv = dev->private;
>
>   	iobase = it->options[0];
>   	irq = it->options[1];
>

Yes, devpriv is no longer needed here.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/