linux-kernel - Re: [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54CA47AB.5070505@mev.co.uk>
Date:	Thu, 29 Jan 2015 14:46:03 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables
 that is never used

On 28/01/15 22:37, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/ni_mio_cs.c |    3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_cs.c b/drivers/staging/comedi/drivers/ni_mio_cs.c
> index 9b201e4..b152330 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_cs.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_cs.c
> @@ -163,7 +163,6 @@ static int mio_cs_auto_attach(struct comedi_device *dev,
>   {
>   	struct pcmcia_device *link = comedi_to_pcmcia_dev(dev);
>   	static const struct ni_board_struct *board;
> -	struct ni_private *devpriv;
>   	int ret;
>
>   	board = ni_getboardtype(dev, link);
> @@ -188,8 +187,6 @@ static int mio_cs_auto_attach(struct comedi_device *dev,
>   	if (ret)
>   		return ret;
>
> -	devpriv = dev->private;
> -
>   	return ni_E_init(dev, 0, 1);
>   }
>
>

Yes, devpriv is not needed here.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/