linux-kernel - Re: [PATCH] staging: comedi: drivers: rtd520: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54CA5203.5000508@mev.co.uk>
Date:	Thu, 29 Jan 2015 15:30:11 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: rtd520: Removed variables that
 is never used

On 28/01/15 22:38, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>   drivers/staging/comedi/drivers/rtd520.c |    6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
> index 581aa58..305631c 100644
> --- a/drivers/staging/comedi/drivers/rtd520.c
> +++ b/drivers/staging/comedi/drivers/rtd520.c
> @@ -1031,8 +1031,6 @@ static int rtd_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>   static int rtd_ai_cancel(struct comedi_device *dev, struct comedi_subdevice *s)
>   {
>   	struct rtd_private *devpriv = dev->private;
> -	u32 overrun;
> -	u16 status;
>
>   	/* pacer stop source: SOFTWARE */
>   	writel(0, dev->mmio + LAS0_PACER_STOP);
> @@ -1040,8 +1038,8 @@ static int rtd_ai_cancel(struct comedi_device *dev, struct comedi_subdevice *s)
>   	writel(0, dev->mmio + LAS0_ADC_CONVERSION);
>   	writew(0, dev->mmio + LAS0_IT);
>   	devpriv->ai_count = 0;	/* stop and don't transfer any more */
> -	status = readw(dev->mmio + LAS0_IT);
> -	overrun = readl(dev->mmio + LAS0_OVERRUN) & 0xffff;
> +	readw(dev->mmio + LAS0_IT);
> +	readl(dev->mmio + LAS0_OVERRUN) & 0xffff;

The ' & 0xffff' part produces compiler warnings.

Those two lines can be removed.  The values read were previously only 
used in a kernel log message.

>   	writel(0, dev->mmio + LAS0_ADC_FIFO_CLEAR);
>   	return 0;
>   }
>


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/