lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Jan 2015 16:26:46 +0000 From: "Ong, Boon Leong" <boon.leong.ong@...el.com> To: Bryan O'Donoghue <pure.logic@...us-software.ie>, Ingo Molnar <mingo@...hat.com> CC: Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>, "dvhart@...radead.org" <dvhart@...radead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Andy Shevchenko <andy.shevchenko@...il.com>, Ingo Molnar <mingo@...nel.org> Subject: RE: [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000 >On 29/01/15 15:40, Bryan O'Donoghue wrote: >>> It would be nice to have two variants (1) index based & (2) address >>> based. >> >> Understood. The direction from Ingo was to have address based external >> interface imr_del_range() and support an index based internal >> imr_clear() - internally. >> >> So - in order to get test coverage - I'll move the self-test code back >> into the main IMR code It will be nice to have the separation of test code. However, that also means the index-based variant needs to be external function. Ingo, what is your preference? >> >> Not as pretty that way - but better coverage :) > >Talking to myself in public... > >Second (third) thought - there's no advantage to moving the test code back in - >since imr_add_range() won't return the index anymore... It does. See below from v6: + ret = imr_write(idev, reg, &imr, lock); ^^ =========== IMR ID + +done: + mutex_unlock(&idev->lock); + return ret == 0 ? reg : ret; ^^ ============ IMR ID +} +EXPORT_SYMBOL(imr_add_range); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists