linux-kernel - RE: [PATCH] einj: Documentation text corrections and streamlining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F329C0656@ORSMSX114.amr.corp.intel.com>
Date:	Thu, 29 Jan 2015 19:40:17 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	linux-edac <linux-edac@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] einj: Documentation text corrections and streamlining

> -To use EINJ, make sure the following are enabled in your kernel
> +To use EINJ, make sure the following are options enabled in your kernel
>  configuration:

How about a paragraph telling people how to check whether their platform supports
EINJ before they start building kernels.  Either look for a boot time console log message
like:

ACPI: EINJ 0x000000007370A000 000150 (v01 INTEL           00000001 INTL 00000001)

or look in /sys/firmware/acpi/tables for an "EINJ" file.

If they don't exist - then go into BIOS setup to see if the BIOS has an option to enable error injection.

> +BIOS versions based on the ACPI 5.0 specification have more control over
> +the target of the injection. For processor-related errors (type 0x1,
> +0x2 and 0x4) the APIC ID of the target should be provided using the
> param1 file in apei/einj.  ...

This paragraph needs to be updated to refer to the "flags" file. It still just describes
legacy (pre 3.13) behavior. Maybe mention here that for processor errors you typically
want to specify an address and an APIC ID - so flags=0x3 and param1, param2 and param3
are all used?

Rest of it looks good.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/