linux-kernel - Re: [PATCH v2 0/2] ktest: console pty support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150129213939.GA20952@treble.redhat.com>
Date:	Thu, 29 Jan 2015 15:39:39 -0600
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Satoru Takeuchi <satoru.takeuchi@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] ktest: console pty support

On Thu, Jan 29, 2015 at 03:44:41PM -0500, Steven Rostedt wrote:
> On Wed, 28 Jan 2015 13:38:37 -0600
> Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> 
> > These patches can be applied on top of yesterday's "ktest: restore tty settings
> > after closing console" patch.  They create a pty pair for the console to
> > prevent the console child process from messing up ktest's tty settings.
> > 
> > v2 changes:
> > - rebased onto the stty save/restore patch
> > - added a patch to enable user input to the console
> > 
> > Josh Poimboeuf (2):
> >   ktest: give console process a dedicated tty
> >   ktest: enable user input to the console
> > 
> >  tools/testing/ktest/ktest.pl | 117 ++++++++++++++++++++++++++++++++++---------
> >  1 file changed, 93 insertions(+), 24 deletions(-)
> > 
> 
> OK, I applied these and been using ktest since. But after one of my
> tests failed (got a bug report), I had no console. I think there's a
> die someplace that does not put everything back.
> 
> Think you could find out where?

Can you tell if it died via dodie()?  Looks like that wouldn't clean up
the stty settings.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/