linux-kernel - Re: [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Jan 2015 23:04:49 +0100
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Vladimir A. Nazarenko" <naszar@...ru>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that
 is never used

2015-01-29 15:26 GMT+01:00 Ian Abbott <abbotti@....co.uk>:
> On 28/01/15 22:35, Rickard Strandqvist wrote:
>>
>> Variable ar assigned a value that is never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist
>> <rickard_strandqvist@...ctrumdigital.se>
>> ---
>>   drivers/staging/comedi/drivers/jr3_pci.c |    3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c
>> b/drivers/staging/comedi/drivers/jr3_pci.c
>> index 81fab2d..5d4cca7 100644
>> --- a/drivers/staging/comedi/drivers/jr3_pci.c
>> +++ b/drivers/staging/comedi/drivers/jr3_pci.c
>> @@ -520,10 +520,9 @@ static struct jr3_pci_poll_delay
>> jr3_pci_poll_subdevice(struct comedi_subdevice
>>                         result = poll_delay_min_max(20, 100);
>>                 } else {
>>                         /* Set full scale */
>> -                       struct six_axis_t min_full_scale;
>>                         struct six_axis_t max_full_scale;
>>
>> -                       min_full_scale = get_min_full_scales(channel);
>> +                       get_min_full_scales(channel);
>>                         max_full_scale = get_max_full_scales(channel);
>>                         set_full_scales(channel, max_full_scale);
>>
>>
>
> Yes, it doesn't appear to be needed.  The driver used to have some kernel
> logs that output the min and max full scale information, but it didn't do
> anything else with min_full_scale.
>
> The call to get_min_full_scales() and the function itself can also be
> removed.
>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-


Hi

Ok good, new patch on the way!

Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/