linux-kernel - Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Jan 2015 17:46:33 -0600
From:	Chris Rorvick <chris@...vick.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Vincenzo Scotti <vinc94@...il.com>,
	Roberta Dobrescu <roberta.dobrescu@...il.com>,
	Sachin Kamat <sachin.kamat@...sung.com>,
	Simon Horman <horms+renesas@...ge.net.au>,
	Ebru Akagunduz <ebru.akagunduz@...il.com>,
	Magnus Damm <damm+renesas@...nsource.se>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is
 never used

On Thu, Jan 29, 2015 at 3:52 PM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> The last one was more interesting, se below.
> But I can not really see how any error should be handled here?
> Proposal to change to:
>
>   if (kstrtol(tempbuf, 16, &num) == 0 && num == 0)

That whole chunk of code looks odd.  Why the base 16 conversion when
we already know it's a decimal digit?  Seems like this would work
without the hassle of the string conversion:

-- >8 --

--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -3262,16 +3262,7 @@ static void __init nbu2ss_drv_set_ep_info(
        ep->ep.ops = &nbu2ss_ep_ops;

        if (isdigit(name[2])) {
-
-               long    num;
-               int     res;
-               char    tempbuf[2];
-
-               tempbuf[0] = name[2];
-               tempbuf[1] = '\0';
-               res = kstrtol(tempbuf, 16, &num);
-
-               if (num == 0)
+               if (name[2] == '0')
                        ep->ep.maxpacket = EP0_PACKETSIZE;
                else
                        ep->ep.maxpacket = EP_PACKETSIZE;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/