linux-kernel - Re: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150128112339.164c55fd@recife.lan>
Date:	Wed, 28 Jan 2015 11:23:39 -0200
From:	Mauro Carvalho Chehab <mchehab@....samsung.com>
To:	Sumit Semwal <sumit.semwal@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
	linux-arm-kernel@...ts.infradead.org, rmk+kernel@....linux.org.uk,
	airlied@...ux.ie, kgene@...nel.org, daniel.vetter@...el.com,
	thierry.reding@...il.com, pawel@...iak.com,
	m.szyprowski@...sung.com, gregkh@...uxfoundation.org,
	linaro-kernel@...ts.linaro.org, robdclark@...il.com,
	daniel@...ll.ch, intel-gfx@...ts.freedesktop.org,
	linux-tegra@...r.kernel.org, inki.dae@...sung.com
Subject: Re: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily
 extensible

Em Wed, 28 Jan 2015 18:24:03 +0530
Sumit Semwal <sumit.semwal@...aro.org> escreveu:

> +/**
> + * helper macro for exporters; zeros and fills in most common values
> + */
> +#define DEFINE_DMA_BUF_EXPORT_INFO(a)	\
> +	struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME }
> +

I suspect that this will let the other fields not initialized.

You likely need to do:

#define DEFINE_DMA_BUF_EXPORT_INFO(a)	\
	struct dma_buf_export_info a = { 	\
	.exp_name = KBUILD_MODNAME;		\
	.fields = 0;				\
...
}

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/