lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Jan 2015 17:57:28 +0530 From: Sumit Semwal <sumit.semwal@...aro.org> To: Daniel Thompson <daniel.thompson@...aro.org> Cc: LKML <linux-kernel@...r.kernel.org>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, DRI mailing list <dri-devel@...ts.freedesktop.org>, Linaro MM SIG Mailman List <linaro-mm-sig@...ts.linaro.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, rmk+kernel@....linux.org.uk, Dave Airlie <airlied@...ux.ie>, kgene@...nel.org, daniel.vetter@...el.com, Thierry Reding <thierry.reding@...il.com>, Pawel Osciak <pawel@...iak.com>, Marek Szyprowski <m.szyprowski@...sung.com>, Mauro Carvalho Chehab <mchehab@....samsung.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Linaro Kernel Mailman List <linaro-kernel@...ts.linaro.org>, intel-gfx@...ts.freedesktop.org, linux-tegra@...r.kernel.org Subject: Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible On 28 January 2015 at 16:50, Daniel Thompson <daniel.thompson@...aro.org> wrote: > On 28/01/15 06:00, Sumit Semwal wrote: <snip> >> +/** >> + * helper macro for exporters; zeros and fills in most common values >> + */ >> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \ >> + struct dma_buf_export_info a = {0}; \ >> + exp_info.exp_name = KBUILD_MODNAME >> + > > This risks generating C99 warnings unless used with care (and only once > per function). Shouldn't this be more like: > > #define DEFINE_DMA_BUF_EXPORT_INFO(a) \ > struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME } > Ah! My bad; thanks for catching this, Daniel; I'll send out the updated patch in a minute! > Daniel. > -- Thanks and regards, Sumit Semwal Kernel Team Lead - Linaro Mobile Group Linaro.org │ Open source software for ARM SoCs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists