linux-kernel - Re: [PATCH v2] lib/checksum.c: fix carry in csum_tcpudp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1422450258.29618.43.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 28 Jan 2015 05:04:18 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Karl Beldan <karl.beldan@...il.com>
Cc:	Karl Beldan <karl.beldan@...ierawaves.com>,
	Al Viro <viro@...IV.linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Mike Frysinger <vapier@...too.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] lib/checksum.c: fix carry in csum_tcpudp_nofold

On Wed, 2015-01-28 at 10:58 +0100, Karl Beldan wrote:
> The carry from the 64->32bits folding was dropped, e.g with:
> saddr=0xFFFFFFFF daddr=0xFF0000FF len=0xFFFF proto=0 sum=1,
> csum_tcpudp_nofold returned 0 instead of 1.
> 
> Signed-off-by: Karl Beldan <karl.beldan@...ierawaves.com>
> Cc: Al Viro <viro@...IV.linux.org.uk>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Mike Frysinger <vapier@...too.org>
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org
> ---
>  lib/checksum.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/