linux-kernel - Re: [PATCH v3 06/10] ASoC: tegra: Add a control for the headphone switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150128110230.GQ21293@sirena.org.uk>
Date:	Wed, 28 Jan 2015 11:02:30 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc:	linux-kernel@...r.kernel.org,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Dylan Reid <dgreid@...omium.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Simon Glass <sjg@...omium.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Wolfram Sang <wsa@...-dreams.de>, alsa-devel@...a-project.org,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH v3 06/10] ASoC: tegra: Add a control for the headphone
 switch

On Wed, Jan 28, 2015 at 11:51:04AM +0100, Tomeu Vizoso wrote:

> To be used by userspace when the headphones jack is plugged in.

>  static const struct snd_kcontrol_new tegra_max98090_controls[] = {
> +	SOC_DAPM_PIN_SWITCH("Headphones"),
>  	SOC_DAPM_PIN_SWITCH("Speakers"),
>  };

Why is userspace doing this?  If this is supposed to be associated with
the jack detection I'd expect us to be doing this in kernel.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)