linux-kernel - Re: [PATCH 2/4] mm: split up mm_struct to separate header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54C9B584.6060302@roeck-us.net>
Date:	Wed, 28 Jan 2015 20:22:28 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
CC:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] mm: split up mm_struct to separate header file

On 01/28/2015 04:30 PM, Kirill A. Shutemov wrote:
> On Wed, Jan 28, 2015 at 03:17:42PM +0200, Kirill A. Shutemov wrote:
>> We want to use __PAGETABLE_PMD_FOLDED in mm_struct to drop nr_pmds if
>> pmd is folded. __PAGETABLE_PMD_FOLDED is defined in <asm/pgtable.h>, but
>> <asm/pgtable.h> itself wants <linux/mm_types.h> for struct page
>> definition.
>>
>> This patch move mm_struct definition into separate header file in order
>> to fix circular header dependencies.
>>
>> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
>
> Guenter, below is update for the patch. It doesn't fix all the issues, but
> you should see an improvement. I'll continue with this tomorrow.

Yes, this is much better than before.

Build results:
	total: 134 pass: 122 fail: 12
Failed builds:
	arm:imx_v6_v7_defconfig
	arm:s3c6400_defconfig
	cris:artpec_3_defconfig
	cris:etraxfs_defconfig
	hexagon:defconfig
	m68k:m5475evb_defconfig
	mips:allmodconfig
	s390:defconfig
	sparc64:defconfig
	sparc64:allmodconfig
	unicore32:defconfig
	xtensa:allmodconfig
Qemu tests:
	total: 30 pass: 28 fail: 2
Failed tests:
	sparc64:sparc_smp_defconfig
	sparc64:sparc_nosmp_defconfig

Some of the problems are inherited from mmotm.
Here are the mmotm build results (v3.19-rc6-462-g995c249):
	total: 134 pass: 128 fail: 6
Failed builds:
	arm:imx_v6_v7_defconfig
	arm:s3c6400_defconfig
	mips:allmodconfig
	sparc64:allmodconfig
	unicore32:defconfig
	xtensa:allmodconfig
Qemu tests:
	total: 30 pass: 30 fail: 0

With this, we can conclude that your patch series still has problems
(at least) with cris, hexagon, m68k, s390, sparc, and unicore32.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/