linux-kernel - RE: [v3 02/26] iommu: Add new member capability to struct irq_remap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E959C4978C3B6342920538CF579893F00238958B@SHSMSX104.ccr.corp.intel.com>
Date:	Thu, 29 Jan 2015 08:34:11 +0000
From:	"Wu, Feng" <feng.wu@...el.com>
To:	David Woodhouse <dwmw2@...radead.org>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"gleb@...nel.org" <gleb@...nel.org>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>,
	"joro@...tes.org" <joro@...tes.org>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
	"jiang.liu@...ux.intel.com" <jiang.liu@...ux.intel.com>,
	"eric.auger@...aro.org" <eric.auger@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"Wu, Feng" <feng.wu@...el.com>
Subject: RE: [v3 02/26] iommu: Add new member capability to struct
 irq_remap_ops



> -----Original Message-----
> From: David Woodhouse [mailto:dwmw2@...radead.org]
> Sent: Wednesday, January 28, 2015 11:23 PM
> To: Wu, Feng
> Cc: tglx@...utronix.de; mingo@...hat.com; hpa@...or.com; x86@...nel.org;
> gleb@...nel.org; pbonzini@...hat.com; joro@...tes.org;
> alex.williamson@...hat.com; jiang.liu@...ux.intel.com; eric.auger@...aro.org;
> linux-kernel@...r.kernel.org; iommu@...ts.linux-foundation.org;
> kvm@...r.kernel.org
> Subject: Re: [v3 02/26] iommu: Add new member capability to struct
> irq_remap_ops
> 
> On Fri, 2014-12-12 at 23:14 +0800, Feng Wu wrote:
> > This patch adds a new member capability to struct irq_remap_ops,
> > this new function ops can be used to check whether some
> > features are supported, such as VT-d Posted-Interrupts.
> 
> > +	/* Check some capability is supported */
> > +	bool (*capability)(enum irq_remap_cap);
> > +
> 
> Does this need to be a function call? Or could we just have a set of
> flags in the irq_remap_ops instead, with less overhead to check them?

Sounds a good idea, I will follow this in the next post! Thanks for the comments!

Thanks,
Feng

> 
> --
> David Woodhouse                            Open Source Technology
> Centre
> David.Woodhouse@...el.com                              Intel
> Corporation