linux-kernel - Re: [PATCH v2] lib/checksum.c: fix carry in csum_tcpudp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150129085538.GA32535@magnum.frso.rivierawaves.com>
Date:	Thu, 29 Jan 2015 09:55:52 +0100
From:	Karl Beldan <karl.beldan@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	karl.beldan@...ierawaves.com, viro@...IV.linux.org.uk,
	eric.dumazet@...il.com, arnd@...db.de, vapier@...too.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] lib/checksum.c: fix carry in csum_tcpudp_nofold

On Wed, Jan 28, 2015 at 10:32:49PM -0800, David Miller wrote:
> From: Karl Beldan <karl.beldan@...il.com>
> Date: Wed, 28 Jan 2015 10:58:11 +0100
> 
> > The carry from the 64->32bits folding was dropped, e.g with:
> > saddr=0xFFFFFFFF daddr=0xFF0000FF len=0xFFFF proto=0 sum=1,
> > csum_tcpudp_nofold returned 0 instead of 1.
> > 
> > Signed-off-by: Karl Beldan <karl.beldan@...ierawaves.com>
> 
> Applied, thanks.

Fengguang's robot reported I managed to break the build, this occurs
when using non-generic do_csum and generic csum_tcpudp_nofold.
I guess a v3 is irrelevant now, should I send another patch for the
build fix only ? Sorry for that.
 
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/