linux-kernel - Re: [PATCH v3 1/5] usb: serial: add register map for F81232

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150129100424.GB5312@localhost>
Date:	Thu, 29 Jan 2015 11:04:24 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Peter Hung <hpeter@...il.com>
Cc:	Johan Hovold <johan@...nel.org>, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	tom_tsai@...tek.com.tw, peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH v3 1/5] usb: serial: add register map for F81232

On Thu, Jan 29, 2015 at 10:37:34AM +0800, Peter Hung wrote:
> Hello.
> 
> 1. For retry Issue:
> 
> These patches is referenced from our other usb serial product. That 
> product maybe not ack the control ep command when It's in very heavily 
> loading. Our workaround is to modify driver to retry more times if it 
> timeout because it's f/w can't upgrade with usb protocol. I will remove 
> the retry mechanic and test for it again.

That sounds good.

> 2. For some function/variable not used:
> 
> The original driver is lacking a lot of feature. My first patch strategy 
> is putting all needed function / variables in patch 1 and apply it in 
> following patches. Sorry for my wrong strategy, I'll change it with more 
> meaningful and logical patchset and resend it.

Perhaps you just need to break the patches up further.

Also if you get checkpatch warnings for code you haven't touched, you
can either ignore them or fix it separately in preparatory patch.

Just try to group related changes together.

> Thanks for your patient and advice.

No worries. 

In the future when posting to the lists, please try to respond inline
(as I am above) rather than top-post, and remove context that isn't
relevant (e.g. code that isn't relevant) for the discussion at hand.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/