linux-kernel - Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Jan 2015 13:25:26 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Peter Hung <hpeter@...il.com>, johan@...nel.org
CC:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, tom_tsai@...tek.com.tw,
	peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

Hello.

On 1/29/2015 5:01 AM, Peter Hung wrote:

> Hello.

     Please don't top-post.

> I had using "scripts/checkpatch.pl -f" to scan original f81232.c.
> It reported with "quoted string split across lines", so I merge these
> 2 strings into 1 in patch 1/5.

    Seems like another unrelated change...

> But it still warning with "line over 80
> character", so I had shorted string with this line.

    Hm, the modern checkpatch.pl shouldn't warn about long lines due to string 
literals used in dev_err(), etc. calls.

> I will refine my patch set again with more attention.

    In any case, don't leave the warnings till some next patch, fix them at once.

> Thanks for your advice.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/