linux-kernel - Re: [PATCH 3/7] [media] staging/davinci/vpfe/dm365: add missing dependencies

Open Source and information security mailing list archives

Date:	Thu, 29 Jan 2015 10:26:08 +0000
From:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	LAK <linux-arm-kernel@...ts.infradead.org>,
	linux-media <linux-media@...r.kernel.org>
Subject: Re: [PATCH 3/7] [media] staging/davinci/vpfe/dm365: add missing dependencies

On Wed, Jan 28, 2015 at 9:17 PM, Arnd Bergmann <arnd@...db.de> wrote:
> This driver can only be built when VIDEO_V4L2_SUBDEV_API
> and VIDEO_DAVINCI_VPBE_DISPLAY are also provided by the
> kernel.
>
> drivers/staging/media/davinci_vpfe/dm365_isif.c: In function '__isif_get_format':
> drivers/staging/media/davinci_vpfe/dm365_isif.c:1410:3: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
>    return v4l2_subdev_get_try_format(fh, pad);
>    ^
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Regards,
--Prabhakar Lad

> ---
>  drivers/staging/media/davinci_vpfe/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/media/davinci_vpfe/Kconfig b/drivers/staging/media/davinci_vpfe/Kconfig
> index 4de2f082491d..f40a06954a92 100644
> --- a/drivers/staging/media/davinci_vpfe/Kconfig
> +++ b/drivers/staging/media/davinci_vpfe/Kconfig
> @@ -2,6 +2,8 @@ config VIDEO_DM365_VPFE
>         tristate "DM365 VPFE Media Controller Capture Driver"
>         depends on VIDEO_V4L2 && ARCH_DAVINCI_DM365 && !VIDEO_DM365_ISIF
>         depends on HAS_DMA
> +       depends on VIDEO_V4L2_SUBDEV_API
> +       depends on VIDEO_DAVINCI_VPBE_DISPLAY
>         select VIDEOBUF2_DMA_CONTIG
>         help
>           Support for DM365 VPFE based Media Controller Capture driver.
> --
> 2.1.0.rc2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives