linux-kernel - Re: [PATCH v2] video: fbdev: fix sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yw1xh9v8bqlh.fsf@unicorn.mansr.com>
Date:	Fri, 30 Jan 2015 08:49:30 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
Cc:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] video: fbdev: fix sys_copyarea

Tomi Valkeinen <tomi.valkeinen@...com> writes:

> On 22/01/15 03:19, Mans Rullgard wrote:
>> The sys_copyarea() function performs the same operation as
>> cfb_copyarea() but using normal memory access instead of I/O
>> accessors.  Since the introduction of sys_copyarea(), there
>> have been two fixes to cfb_copyarea():
>> 
>> - 00a9d699 ("framebuffer: fix cfb_copyarea")
>> - 5b789da8 ("framebuffer: fix screen corruption when copying")
>> 
>> This patch incorporates the fixes into sys_copyarea() as well.
>> 
>> Signed-off-by: Mans Rullgard <mans@...sr.com>
>> ---
>> Changed in v2:
>>  - Fixed wrong first/last calculation in bitcpy_rev()
>> ---
>>  drivers/video/fbdev/core/syscopyarea.c | 137 ++++++++++++++++-----------------
>>  1 file changed, 65 insertions(+), 72 deletions(-)
>
> Thanks, queued for 3.20.
>
> This makes me wonder, though, if the sys and cfb versions could be
> somehow combined...

I would have done it by #including a common template with different
macro definitions for the memory access operations.

-- 
Måns Rullgård
mans@...sr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/