lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 30 Jan 2015 09:50:48 +0100 From: Paolo Bonzini <pbonzini@...hat.com> To: Joe Perches <joe@...ches.com>, Radim Krčmář <rkrcmar@...hat.com> CC: linux-kernel@...r.kernel.org, kvm@...r.kernel.org, Nadav Amit <namit@...technion.ac.il>, Gleb Natapov <gleb@...nel.org> Subject: Re: [PATCH 1/8] KVM: x86: return bool from kvm_apic_match*() On 29/01/2015 23:10, Joe Perches wrote: > On Thu, 2015-01-29 at 22:48 +0100, Radim Krčmář wrote: >> And don't export the internal ones while at it. > [] >> -int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda) >> +static bool kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda) >> { >> int result = 0; >> u32 logical_id; >> @@ -626,7 +626,7 @@ int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda) >> return result; >> } >> >> -int kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source, >> +bool kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source, >> int short_hand, unsigned int dest, int dest_mode) >> { >> int result = 0; > > Perhaps these result variables should be bool. See patch 2. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists