linux-kernel - Re: [PATCH v8 0/2] Imagination Technologies PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Jan 2015 10:18:34 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Ezequiel Garcia <ezequiel.garcia@...tec.com>
Cc:	Andrew Bresticker <abrestic@...omium.org>,
	James Hartley <james.hartley@...tec.com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pwm@...r.kernel.org, vladimir_zapolskiy@...tor.com
Subject: Re: [PATCH v8 0/2] Imagination Technologies PWM support

On Thu, Jan 29, 2015 at 01:32:09PM -0300, Ezequiel Garcia wrote:
> On 01/20/2015 07:52 AM, Ezequiel Garcia wrote:
> > 
> > 
> > On 01/09/2015 02:54 PM, Ezequiel Garcia wrote:
> >> A new round for the IMG PWM driver.
> >>
> >> The IMG PWM controller is muxed with a PDM controller, through a shared
> >> so-called periph register bit, which sets the output as PWM or PDM.
> >> Because this register is not part of the pin controller block, but rather
> >> PWM/PDM specific, and because the register is also used to set the PDM value,
> >> it is simpler to use a regmap-based syscon to deal with it.
> >>
> >> This time, I'm removing the PDM driver from the submission and submitting the PWM
> >> alone. The PDM was written as a misc driver, but had some design issues, so for
> >> now I'm proposing to merge the PWM only.
> >>
> >> The series is based on v3.19-rc3. If at all possible I'd like to see this merged
> >> for v3.20.
> >>
> > 
> > Thierry,
> > 
> > Any comments on this? Any chance we merge it in time for v3.20?
> > It's -rc5 already and I've started to worry.
> > 
> 
> Thierry,
> 
> I'm very sorry to be so bothering, but I got no news from you and it's
> -rc6 already. I'd say I'll resend this series to Andrew Morton, hoping
> we can merge this for v3.20.
> 
> Please let me know if you'll be able to pick this.

I can pick it up if you make up your mind about the license. The header
comment says GPL v2 or later, but MODULE_LICENSE has "GPL v2", which
does not include the "or later" part.

Also you're making it especially difficult to build-test by not
providing even the basic bits of your SoC support first. All even
linux-next seems to have for the Pistachio SoC is the addition of a
compatible string to the dw-mmc driver.

I'll take the PWM driver, but I'll assume that you'll eventually have
more pieces available, in which case I'd appreciate a note so I can
update my build scripts.

Thierry

Content of type "application/pgp-signature" skipped