[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54CB6253.5080906@mev.co.uk>
Date: Fri, 30 Jan 2015 10:52:03 +0000
From: Ian Abbott <abbotti@....co.uk>
To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
H Hartley Sweeten <hsweeten@...ionengravers.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Bernd Porr <mail@...ndporr.me.uk>,
Chase Southwood <chase.southwood@...il.com>,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: comedi: drivers: usbduxsigma: Removed variables
that is never used
On 29/01/15 22:50, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
> drivers/staging/comedi/drivers/usbduxsigma.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
> index dc19435..185f2d1 100644
> --- a/drivers/staging/comedi/drivers/usbduxsigma.c
> +++ b/drivers/staging/comedi/drivers/usbduxsigma.c
> @@ -215,7 +215,6 @@ static void usbduxsigma_ai_handle_urb(struct comedi_device *dev,
> struct usbduxsigma_private *devpriv = dev->private;
> struct comedi_async *async = s->async;
> struct comedi_cmd *cmd = &async->cmd;
> - unsigned int dio_state;
> uint32_t val;
> int ret;
> int i;
> @@ -224,9 +223,6 @@ static void usbduxsigma_ai_handle_urb(struct comedi_device *dev,
> if (devpriv->ai_counter == 0) {
> devpriv->ai_counter = devpriv->ai_timer;
>
> - /* get the state of the dio pins to allow external trigger */
> - dio_state = be32_to_cpu(devpriv->in_buf[0]);
> -
> /* get the data from the USB bus and hand it over to comedi */
> for (i = 0; i < cmd->chanlist_len; i++) {
> /* transfer data, note first byte is the DIO state */
>
Reviewed-by: Ian Abbott <abbotti@....co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@....co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists